Skip to content

[Backport release-24.05] haskellPackages.immortal: disable flaky tests on darwin#361755

Merged
vcunat merged 1 commit intorelease-24.05from
backport-355766-to-release-24.05
Dec 5, 2024
Merged

[Backport release-24.05] haskellPackages.immortal: disable flaky tests on darwin#361755
vcunat merged 1 commit intorelease-24.05from
backport-355766-to-release-24.05

Conversation

@nixpkgs-ci
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Dec 4, 2024 •
edited by vcunat
Loading

Bot-based backport to release-24.05, triggered by a label in #355766.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@sternenseemann @github-actions
haskellPackages.immortal: disable flaky tests on darwin
44ef00a 
It took 5 tries in <https://hydra.nixos.org/eval/1809897> for the tests
to succeed on x86_64 and aarch64 darwin, respectively.

(cherry picked from commit 57fd2fc)
@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 4, 2024
Merged
13 tasks
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Dec 4, 2024
@vcunat
Copy link
Member

vcunat commented Dec 4, 2024

This started blocking the nixpkgs-24.05-darwin channel:
https://hydra.nixos.org/build/281091274

@vcunat
Copy link
Member

vcunat commented Dec 4, 2024

Right know I'm not yet sure whether this causes many linux rebuilds. That would be a bit unpleasant.

@vcunat
Copy link
Member

vcunat commented Dec 4, 2024

Ah, configuration-darwin.nix. But I'll check rebuilds locally anyway :-)

@sternenseemann
Copy link
Member

sternenseemann commented Dec 4, 2024

Should be zero linux rebuilds.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 5, 2024
@vcunat vcunat merged commit 3cf437f into release-24.05 Dec 5, 2024
@vcunat vcunat deleted the backport-355766-to-release-24.05 branch December 5, 2024 05:45
@vcunat
Copy link
Member

vcunat commented Dec 5, 2024

Yes, I forgot to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maralorn maralorn Awaiting requested review from maralorn

@ncfavier ncfavier Awaiting requested review from ncfavier

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vcunat @sternenseemann