release-cross: replace x86_64-darwin with aarch64-darwin#361521
Merged
Artturin merged 1 commit intoNixOS:stagingfrom Dec 12, 2024
Merged
release-cross: replace x86_64-darwin with aarch64-darwin#361521Artturin merged 1 commit intoNixOS:stagingfrom
Artturin merged 1 commit intoNixOS:stagingfrom
Conversation
github-actions
bot
added
the
8.has: documentation
Member
Author
From Matrix:
So this would actually put some load off of darwin builders, which is a nice side benefit. |
ofborg
bot
added
6.topic: cross-compilation
13 tasks
Contributor
|
This looks lovely, as it would make cross compilation from arm-darwin much faster. |
Contributor
|
How about the documentation of Nixpkgs? I know of that thing, but there are probably more places? |
13 tasks
wolfgangwalther
pushed a commit
that referenced
this pull request
Apr 23, 2025
in #361521 this was changed to aarch64-darwin.
mkg20001
pushed a commit
to mkg20001/nixpkgs
that referenced
this pull request
Apr 29, 2025
in NixOS#361521 this was changed to aarch64-darwin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose trading
x86_64-darwinforaarch64-darwinas the main darwin cross-compiling build platform. ARM Macs have been introduced in 2020 and the last Intel MacBooks have been discontinued in 2023 so I think most people would findaarch64-darwinmore useful here.See #284465
I guess the main question here is whether the
aarch64-darwinbuilders are numerous enough to support this without slowing down native builds too much (relative tox86_64-darwin).Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.