Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
18 tasks
SuperSandro2000
approved these changes
Dec 3, 2024
PedroHLC
reviewed
Dec 18, 2024
Comment on lines
+9
to
+10
| (kernel.structuredExtraConfig ? PREEMPT_RT) | ||
| && (kernel.structuredExtraConfig.PREEMPT_RT == lib.kernel.yes); |
Member
There was a problem hiding this comment.
This looks for it in patched kernels, but don't look for it in linuxManualConfig-based kernels.
Member
There was a problem hiding this comment.
As in, linuxManualConfig doesn't even generate structureExtraConfig. There, this may live in kernel.config.CONFIG_PREEMPT_RT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
This PR supersedes #263950. It updates lkrg to its latest version and unbreaks it on newer kernels.
The previous PR disabled some features by default: #263950 (review) Since these are also configurable via module parameters, this doesn't seem sensible and the user needs to do the right thing here.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.