Skip to content

lib/types: init {types.attrsWith}#361391

Merged
infinisil merged 7 commits intoNixOS:masterfrom
hsjobeki:lib/attrsWith-3
Dec 4, 2024
Merged

lib/types: init {types.attrsWith}#361391
infinisil merged 7 commits intoNixOS:masterfrom
hsjobeki:lib/attrsWith-3

Conversation

@hsjobeki
Copy link
Contributor

@hsjobeki hsjobeki commented Dec 3, 2024

Reapply #354738

Fixes: #361334

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: module system About "NixOS" module system internals 6.topic: lib The Nixpkgs function library labels Dec 3, 2024
@hsjobeki hsjobeki mentioned this pull request Dec 3, 2024
13 tasks
@nix-owners nix-owners bot requested review from infinisil and roberth December 3, 2024 09:07
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Eval summary

  • Added packages: 0
  • Removed packages: 0
  • Changed packages: 3
  • Rebuild Linux: 3
  • Rebuild Darwin: 1

@ofborg ofborg bot added the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label Dec 3, 2024
@infinisil infinisil merged commit 5adee31 into NixOS:master Dec 4, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/use-cases-of-option-type-internals/57317/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: lib The Nixpkgs function library 6.topic: module system About "NixOS" module system internals 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants