Skip to content

nixos/ananicy: fix eval when hardened kernel is used with ananicy-cpp#361172

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
JohnRTitor:ananicy-module
Dec 3, 2024
Merged

nixos/ananicy: fix eval when hardened kernel is used with ananicy-cpp#361172
JohnRTitor merged 1 commit intoNixOS:masterfrom
JohnRTitor:ananicy-module

Conversation

@JohnRTitor
Copy link
Member

@JohnRTitor JohnRTitor commented Dec 2, 2024

Fixes #360957

Things done


Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 2, 2024
@JohnRTitor
Copy link
Member Author

@MrQubo JohnRTitor/nix-conf@d5b1cfa you can test it like this . I have seen your tracefs solution (but I should probably ask @Artturin as I don't know much about it). I would prefer getting this fix merged first.

@JohnRTitor JohnRTitor requested a review from Artturin December 2, 2024 18:57
@JohnRTitor
Copy link
Member Author

@ofborg eval

@JohnRTitor
Copy link
Member Author

That test is broken because of #354738, which already got reverted

@JohnRTitor JohnRTitor merged commit 2bedc78 into NixOS:master Dec 3, 2024
@JohnRTitor JohnRTitor deleted the ananicy-module branch December 3, 2024 11:44
@MrQubo
Copy link
Contributor

MrQubo commented Dec 3, 2024

@MrQubo JohnRTitor/nix-conf@d5b1cfa you can test it like this . I have seen your tracefs solution (but I should probably ask @Artturin as I don't know much about it). I would prefer getting this fix merged first.

I'm using channels though. I just replaced whole nixos channel and rebuilt my own configuration.

But thanks for the idea of just importing one module, as replacing whole channel sometimes breaks other parts of configuration (especially because my configuration is for stable channel).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nixos/ananicy: impossible to use ananicy-cpp with bpf enabled on hardened kernel

2 participants