[release-24.11] GitHub Action eval backports#361168
Merged
Mic92 merged 7 commits intoNixOS:release-24.11from Dec 3, 2024
Merged
[release-24.11] GitHub Action eval backports#361168Mic92 merged 7 commits intoNixOS:release-24.11from
Mic92 merged 7 commits intoNixOS:release-24.11from
Conversation
(cherry picked from commit d65d18f)
(cherry picked from commit 5978e7f)
For PRs whose commits end up as HEAD of master like NixOS@bcc5c14, there might be workflow runs associated with both PRs and pushes. Only the push event is the one that will run fully and should be used to compare against. So far it didn't distinguish between the two events, causing it to sometimes pick the wrong one and then fail to download non-existent artifacts: https://github.com/NixOS/nixpkgs/actions/runs/12092053414/job/33721377179 This commit fixes that by ensuring that the push event result is compared against (cherry picked from commit b3e8e25)
Previously the labels would never be removed, even if the number of rebuilds changed (cherry picked from commit ea65e30)
(cherry picked from commit 0e27bc3)
(cherry picked from commit 8b7ed6e)
…ns in a summary list (cherry picked from commit 006691d)
github-actions
bot
added
6.topic: policy discussion
This was referenced Dec 2, 2024
nix-owners
bot
requested review from
LeSuisse,
Mic92,
mweinelt,
philiptaron,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 1-10
TheGiraffe3
approved these changes
Dec 3, 2024
ofborg
bot
added
10.rebuild-darwin: 0
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports these PRs:
No other PRs need to be backported to get the GitHub Action eval in sync on master and release-24.11.
Ping @Mic92 @TheGiraffe3 @drupol @itepastra @azuwis
Things done
Add a 👍 reaction to pull requests you find important.