workflows/eval: Add the eval summary as a comment#361061
Conversation
github-actions
bot
added
6.topic: policy discussion
|
@Mic92 @FliegendeWurst What do you think? |
|
I think the main benefit here is the link to the evaluation results. Numbers are already provided by the labels |
nix-owners
bot
requested review from
LeSuisse,
Mic92,
infinisil,
mweinelt,
risicle and
zowoq
|
works: #361344 (comment) |
|
Is this going to be posted on every force push? If yes: strong 👎 Edit: I see |
|
Hmm not sure if I like having such a comment on every single PR |
|
How about only post the comment, if more than 10 packages are added/removed/changed? Like this #361365 (comment) |
|
It would be great if this could somehow be integrated with the job requesting reviews from OWNERS. What I mean is that it would be great if the bot could post a comment before the reviews are requested and then would update it later on... that could reduce the number of notifications a bit? You'd only receive a notification for review once and not a second one for the comment a bit later. |
|
Does requesting reviews actually creates a notification? I don't think it did this for me in the past. I agree with @infinisil I noticed that I found myself having to open updated pull requests more often just to see it was only yet another bot comment: #361388 |
If that was not the case, then those review requests would be useless. I get emails like this:
And then a few minutes later another comment about the eval result - which I really don't care about at this stage. I might care about it for my own PRs, but also... not really. I would really like to see the evaluation results on a quick glance once I look at the PR anyway, but I don't want to be notified about them. |
5 participants
See it in action azuwis#9
Make #360339 more discoverable.
Will post a comment like:
Eval summary
Compared to #360962:
See workflows/eval: Add the step summary as a comment #360962 (comment)
See workflows/eval: Add the step summary as a comment #360962 (comment)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.