workflows/eval: Add the step summary as a comment#360962
Closed
azuwis wants to merge 1 commit intoNixOS:masterfrom
Closed
workflows/eval: Add the step summary as a comment#360962azuwis wants to merge 1 commit intoNixOS:masterfrom
azuwis wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: policy discussion
nix-owners
bot
requested review from
LeSuisse,
Mic92,
infinisil,
mweinelt,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
Mic92
reviewed
Dec 2, 2024
| REPOSITORY: ${{ github.repository }} | ||
| NUMBER: ${{ github.event.number }} | ||
|
|
||
| - name: Adding comments |
Member
There was a problem hiding this comment.
I am not so sure about comments here. This will be posted everytime someone pushes to a pull request and a new eval starts. This sounds noisy to me and makes long-running pull requests reviews hard to read. We mostly care for these changes if they are mass rebuilds and for that we have labels.
Contributor
Author
There was a problem hiding this comment.
How about gh pr comment "$NUMBER" --edit-last --body-file comparison/step-summary.md?
It should post only 1 comment, and update it on every push.
Member
|
I am not in favor of this change. It will make the GH search results even more useless, since searching for a package would then also find all dependency updates. |
Member
|
That's also a good point. Less close it. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See it in action azuwis#7
Make #360339 more discoverable.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.