Skip to content

[Backport release-24.05] gitlab: 17.3.7 -> 17.5.2#360348

Merged
leona-ya merged 1 commit intoNixOS:release-24.05from
xanderio:backport-360160-to-release-24.05
Dec 8, 2024
Merged

[Backport release-24.05] gitlab: 17.3.7 -> 17.5.2#360348
leona-ya merged 1 commit intoNixOS:release-24.05from
xanderio:backport-360160-to-release-24.05

Conversation

@xanderio
Copy link
Contributor

(cherry picked from commit eebd4c3)

#360160

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

(cherry picked from commit eebd4c3)
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 30, 2024
@xanderio xanderio changed the title [backport release-24.05] gitlab: 17.3.7 -> 17.5.2 [Backport release-24.05] gitlab: 17.3.7 -> 17.5.2 Nov 30, 2024
@xanderio xanderio added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 30, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 30, 2024
Copy link
Contributor

@osnyx osnyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing cherry-picks check can be attributed to xanderio@571c71e not being present in 24.05.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 3, 2024
@leona-ya leona-ya merged commit d35a3a5 into NixOS:release-24.05 Dec 8, 2024
@xanderio xanderio deleted the backport-360160-to-release-24.05 branch December 8, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants