workflows/eval: add markdown of added, removed and changed by itepastra · Pull Request #360339 · NixOS/nixpkgs

itepastra · 2024-11-30T08:28:04Z

Makes the github action for eval output the added, removed and changed paths in the summary.

The paths were already available in json format in changed-paths.json.
This PR adds a human-readable representation to the summary of the format (not in a code block)

## Added


## Removed

graalvmCEPackages.graalvm-ce-musl
graalvmCEPackages.stdenv

## Changed

babashka
babashka-unwrapped
bbin
certificate-ripper
clj-kondo
cljfmt
clojure-lsp
cq
dapl-native
dbqn-native
graalvm-ce
graalvmCEPackages.graaljs
graalvmCEPackages.graalnodejs
graalvmCEPackages.graalpy
graalvmCEPackages.graalvm-ce
graalvmCEPackages.truffleruby
jet
neil
obb
scala-update
tests.writers.bin.babashka
tests.writers.simple.babashka
tests.writers.wrapping.babashka
tests.writers.wrapping.babashka-bin
vscode-extensions.betterthantomorrow.calva
yamlscript
zprint

Things done

created itepastra#3 to see what the result looks like

Add a 👍 reaction to pull requests you find important.

Mic92 · 2024-11-30T09:10:40Z

Do you have a test PR, what this looks like? Just make a pull request against your ci-eval-markdown branch.

itepastra · 2024-11-30T10:13:57Z

https://github.com/itepastra/nixpkgs/actions/runs/12095524145/attempts/1#summary-33728887151 <- this is what it currently looks like

ci/eval/default.nix

infinisil

Thanks, LGTM!

azuwis · 2024-11-30T13:26:55Z

ci/eval/default.nix

+        "## Added\n" + (.attrdiff.added | map("- \(. )") | join("\n")) + "\n" +
+        "## Removed\n" + (.attrdiff.removed | map("- \(. )") | join("\n")) + "\n" +
+        "## Changed\n" + (.attrdiff.changed | map("- \(. )") | join("\n")) + "\n"


Suggested change

"## Added\n" + (.attrdiff.added | map("- \(. )") | join("\n")) + "\n" +

"## Removed\n" + (.attrdiff.removed | map("- \(. )") | join("\n")) + "\n" +

"## Changed\n" + (.attrdiff.changed | map("- \(. )") | join("\n")) + "\n"

.attrdiff, .rebuildsByKernel | to_entries[] | "* \(.key | ascii_upcase) \(.value | length | tostring)", " * \(.value[])"

How about this, will produce something like:

Edit: Update to include .rebuildsByKernel

ADDED 0

REMOVED 0

CHANGED 6

hello

tests.checkpointBuildTools

tests.config.allowPkgsInPermittedInsecurePackages

tests.devShellTools.nixos

tests.devShellTools.unstructuredDerivationInputEnv

tests.devShellTools.valueToString

DARWIN 4

hello

tests.checkpointBuildTools

tests.config.allowPkgsInPermittedInsecurePackages

tests.devShellTools.nixos

LINUX 6

hello

tests.checkpointBuildTools

tests.config.allowPkgsInPermittedInsecurePackages

tests.devShellTools.nixos

tests.devShellTools.unstructuredDerivationInputEnv

tests.devShellTools.valueToString

azuwis · 2024-11-30T14:01:13Z

Some experiments:

$ jq -r '.rebuildsByKernel | to_entries[] | "* \(.key) \(.value | length | tostring)", "  * \(.value[])"' < changed-paths.json
* darwin 4
  * hello
  * tests.checkpointBuildTools
  * tests.config.allowPkgsInPermittedInsecurePackages
  * tests.devShellTools.nixos
* linux 6
  * hello
  * tests.checkpointBuildTools
  * tests.config.allowPkgsInPermittedInsecurePackages
  * tests.devShellTools.nixos
  * tests.devShellTools.unstructuredDerivationInputEnv
  * tests.devShellTools.valueToString

darwin 4
- hello
- tests.checkpointBuildTools
- tests.config.allowPkgsInPermittedInsecurePackages
- tests.devShellTools.nixos
linux 6
- hello
- tests.checkpointBuildTools
- tests.config.allowPkgsInPermittedInsecurePackages
- tests.devShellTools.nixos
- tests.devShellTools.unstructuredDerivationInputEnv
- tests.devShellTools.valueToString

azuwis · 2024-11-30T14:15:13Z

$ jq -r '.attrdiff | to_entries[] | "## \(.key | ascii_upcase) \(.value | length | tostring)", "- \(.value[])"'
## ADDED 0
## REMOVED 0
## CHANGED 5
- hello
- tests.checkpointBuildTools
- tests.config.allowPkgsInPermittedInsecurePackages
- tests.devShellTools.nixos
- tests.devShellTools.unstructuredDerivationInputEnv

Can produce very similar result to #360339 (comment)

ADDED 0

REMOVED 0

CHANGED 5

hello
tests.checkpointBuildTools
tests.config.allowPkgsInPermittedInsecurePackages
tests.devShellTools.nixos
tests.devShellTools.unstructuredDerivationInputEnv

azuwis · 2024-11-30T14:44:58Z

Update #360339 (comment):

Use to_entries, less repetition
Include both attrdiff and rebuildsByKernel
Use nested list

See if you like it or not :D

.github/workflows/eval.yml

Mic92 · 2024-12-01T10:39:12Z

@azuwis I took the idea of adding numbers to each section, but also added a truncate function as step summaries have a 1MB size limit. Because of the size limitation, I would for now not include other section and just stick to added/removed/changed.

…ns in a summary list

Mic92 · 2024-12-01T11:00:52Z

I now also added links to the github search: https://gist.github.com/Mic92/b3f1200a4b92535c4dc3ecde9bab6019

github-actions · 2024-12-01T19:44:13Z

Git push to origin failed for release-24.11 with exitcode 1

infinisil · 2024-12-02T18:10:01Z

Manual backport: #361168

infinisil · 2024-12-12T11:13:25Z

Whoops we have a problem:

Error: $GITHUB_STEP_SUMMARY upload aborted, supports content up to a size of 1024k, got 1636k. For more information see: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#adding-a-markdown-summary

Mic92 · 2024-12-12T11:39:38Z

To be honest, do we want those markdown files anyway for mass-rebuilds?
Maybe we can just skip them. Because there is not much point in listing all packages of nixpkgs.

Mic92 · 2024-12-12T11:40:13Z

Maybe we just truncate the document with sed?

Mic92 · 2024-12-12T11:41:11Z

Actually I already did a limit function there. So maybe we just need to adjust the limit to a safe value?

infinisil · 2024-12-12T11:45:27Z

@Mic92 Oh yeah that sounds good

infinisil · 2024-12-12T11:46:31Z

Ideally it also shows how to get the full list

itepastra requested a review from infinisil November 30, 2024 08:28

github-actions bot added 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Nov 30, 2024

nix-owners bot requested review from LeSuisse, Mic92, azuwis, mweinelt, philiptaron, risicle and zowoq November 30, 2024 08:29

itepastra changed the title ~~github/workflows/eval: add markdown of added, removed and changed~~ workflows/eval: add markdown of added, removed and changed Nov 30, 2024

github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 30, 2024

itepastra added a commit to itepastra/nixpkgs that referenced this pull request Nov 30, 2024

hello: change to test NixOS#360339

1a793cf

itepastra force-pushed the ci-eval-markdown branch from 93bde89 to 56d214a Compare November 30, 2024 10:02

Mic92 reviewed Nov 30, 2024

View reviewed changes

ci/eval/default.nix Outdated Show resolved Hide resolved

itepastra force-pushed the ci-eval-markdown branch from 56d214a to 963677a Compare November 30, 2024 11:35

github/workflows/eval: add markdown of added, removed and changed

0e27bc3

itepastra force-pushed the ci-eval-markdown branch from 963677a to 0e27bc3 Compare November 30, 2024 12:48

infinisil approved these changes Nov 30, 2024

View reviewed changes

azuwis reviewed Nov 30, 2024

View reviewed changes

itepastra commented Dec 1, 2024

View reviewed changes

.github/workflows/eval.yml Outdated Show resolved Hide resolved

github/workflows/eval: limit number of packages in markdown

8b7ed6e

Mic92 force-pushed the ci-eval-markdown branch from 929c3b6 to 8b7ed6e Compare December 1, 2024 10:07

github/workflows/eval: add nixos package search links and wrap sectio…

006691d

…ns in a summary list

Mic92 merged commit eaae909 into NixOS:master Dec 1, 2024

Mic92 mentioned this pull request Dec 1, 2024

Replacing ofBorg with GitHub Actions #355847

Closed

7 tasks

JohnRTitor added the backport release-24.11 label Dec 1, 2024

itepastra deleted the ci-eval-markdown branch December 1, 2024 20:40

This was referenced Dec 2, 2024

workflows/eval: Add the step summary as a comment #360962

Closed

workflows/eval: Add the eval summary as a comment #361061

Merged

infinisil mentioned this pull request Dec 2, 2024

[release-24.11] GitHub Action eval backports #361168

Merged

Uh oh!

Conversation

itepastra commented Nov 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

Mic92 commented Nov 30, 2024

Uh oh!

itepastra commented Nov 30, 2024

Uh oh!

Uh oh!

infinisil left a comment

Choose a reason for hiding this comment

Uh oh!

azuwis Nov 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azuwis commented Nov 30, 2024

Uh oh!

azuwis commented Nov 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ADDED 0

REMOVED 0

CHANGED 5

Uh oh!

azuwis commented Nov 30, 2024

Uh oh!

Uh oh!

Mic92 commented Dec 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mic92 commented Dec 1, 2024

Uh oh!

github-actions bot commented Dec 1, 2024

Uh oh!

infinisil commented Dec 2, 2024

Uh oh!

infinisil commented Dec 12, 2024

Uh oh!

Mic92 commented Dec 12, 2024

Uh oh!

Mic92 commented Dec 12, 2024

Uh oh!

Mic92 commented Dec 12, 2024

Uh oh!

infinisil commented Dec 12, 2024

Uh oh!

infinisil commented Dec 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

itepastra commented Nov 30, 2024 •

edited

Loading

azuwis Nov 30, 2024 •

edited

Loading

azuwis commented Nov 30, 2024 •

edited

Loading

Mic92 commented Dec 1, 2024 •

edited

Loading