Skip to content

ci/eval: don't allow IFD#360225

Merged
infinisil merged 1 commit intoNixOS:masterfrom
Mic92:ci-ifd
Nov 29, 2024
Merged

ci/eval: don't allow IFD#360225
infinisil merged 1 commit intoNixOS:masterfrom
Mic92:ci-ifd

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 29, 2024

Things done

Tested in Mic92#40

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92 Mic92 requested a review from infinisil November 29, 2024 20:52
@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Nov 29, 2024
@Mic92 Mic92 marked this pull request as draft November 29, 2024 20:58
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mic92 Mic92 marked this pull request as ready for review November 29, 2024 21:03
@infinisil infinisil merged commit 2aabd11 into NixOS:master Nov 29, 2024
@Mic92 Mic92 deleted the ci-ifd branch November 29, 2024 21:22
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Successfully created backport PR for release-24.11:

@infinisil
Copy link
Member

Manual backport: #361168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants