Skip to content

gitlab: 17.3.7 -> 17.5.2#360160

Merged
leona-ya merged 1 commit intoNixOS:masterfrom
xanderio:gitlab-17.5.2
Nov 30, 2024
Merged

gitlab: 17.3.7 -> 17.5.2#360160
leona-ya merged 1 commit intoNixOS:masterfrom
xanderio:gitlab-17.5.2

Conversation

@xanderio
Copy link
Contributor

@xanderio xanderio commented Nov 29, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 29, 2024
@xanderio xanderio mentioned this pull request Nov 29, 2024
Merged
13 tasks
@xanderio xanderio added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 29, 2024
@ofborg ofborg bot requested review from blitz, globin, krav, talyz and yayayayaka November 30, 2024 06:00
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 30, 2024
@leona-ya leona-ya merged commit 2ba7113 into NixOS:master Nov 30, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-360160-to-release-24.05 origin/release-24.05
cd .worktree/backport-360160-to-release-24.05
git switch --create backport-360160-to-release-24.05
git cherry-pick -x eebd4c3b0133cf3579e2a2c45e0657cccbf9c850

@github-actions github-actions bot mentioned this pull request Nov 30, 2024
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2024

Successfully created backport PR for release-24.11:

@xanderio xanderio mentioned this pull request Nov 30, 2024
Merged
13 tasks
@xanderio xanderio deleted the gitlab-17.5.2 branch November 30, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leona-ya leona-ya leona-ya approved these changes

@krav krav Awaiting requested review from krav

@blitz blitz Awaiting requested review from blitz

@talyz talyz Awaiting requested review from talyz

@globin globin Awaiting requested review from globin

@yayayayaka yayayayaka Awaiting requested review from yayayayaka

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xanderio @leona-ya