buildGoModule: access ldflags and tags __structuredAttrs-agnostically#360037
Merged
ShamrockLee merged 2 commits intoNixOS:stagingfrom Dec 18, 2024
Merged
buildGoModule: access ldflags and tags __structuredAttrs-agnostically#360037ShamrockLee merged 2 commits intoNixOS:stagingfrom
ldflags and tags __structuredAttrs-agnostically#360037ShamrockLee merged 2 commits intoNixOS:stagingfrom
Conversation
github-actions
bot
added
the
6.topic: golang
Contributor
Author
wolfgangwalther
approved these changes
Nov 29, 2024
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
Just looked, didn't build anything.
LGTM
ofborg
bot
added
10.rebuild-darwin: 501+
4 tasks
Contributor
Author
|
The OfBorg builds of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust how
ldflagsandtagsattributes form corresponding flags to make it compatible to__structuredAttrs = true.This change also simplifies how
GOOSandGOARCHare accessed during the build.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.