linuxPackages.cryptodev: 1.13 -> 1.14#359871
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Dec 18, 2024
Merged
Conversation
18 tasks
Contributor
Author
|
MakiseKurisu
approved these changes
Nov 28, 2024
ofborg
bot
added
10.rebuild-darwin: 0
wegank
added
the
12.approvals: 1
moni-dz
approved these changes
Nov 29, 2024
moni-dz
added
12.approvals: 2
Contributor
Author
|
The |
Member
There was a problem hiding this comment.
Suggested change
| pname = "cryptodev-linux-1.14"; | |
| pname = "cryptodev-linux"; | |
| version = "1.14"; |
Contributor
Author
There was a problem hiding this comment.
@SuperSandro2000 Thanks for the review! I've removed the code that appended the kernel version to the derivation name and applied the remaining fixes you suggested. Now it mostly does what other out-of-tree modules do as well.
Contributor
Author
|
Result of 1 package marked as broken and skipped:
18 packages built:
|
wegank
removed
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Update cryptodev to latest version to fix build failure for Linux 5.10.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.