Skip to content

nixos/iso-image: fix isoImage.grubTheme = null;#359374

Merged
ElvishJerricco merged 1 commit intoNixOS:masterfrom
Artturin:grubthemenull
Nov 27, 2024
Merged

nixos/iso-image: fix isoImage.grubTheme = null;#359374
ElvishJerricco merged 1 commit intoNixOS:masterfrom
Artturin:grubthemenull

Conversation

@Artturin
Copy link
Member

@Artturin Artturin commented Nov 26, 2024

Fixes error: cannot coerce null to a string

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jonringer @Artturin
nixos/iso-image: fix isoImage.grubTheme = null;
b5168a9 
Fixes `error: cannot coerce null to a string`
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 26, 2024
@Artturin Artturin mentioned this pull request Nov 26, 2024
Merged
13 tasks
@nix-owners nix-owners bot requested a review from ElvishJerricco November 26, 2024 19:20
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 27, 2024
@ElvishJerricco ElvishJerricco merged commit 98dece1 into NixOS:master Nov 27, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 29, 2024
Merged
1 task
@Artturin Artturin deleted the grubthemenull branch July 23, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElvishJerricco ElvishJerricco Awaiting requested review from ElvishJerricco

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Artturin @ElvishJerricco @jonringer