virtualisation: Use system.build.image, normalize file names#359339
Merged
zimbatm merged 16 commits intoNixOS:masterfrom Nov 29, 2024
Merged
virtualisation: Use system.build.image, normalize file names#359339zimbatm merged 16 commits intoNixOS:masterfrom
zimbatm merged 16 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
phaer
force-pushed
the
virtualisation-images-phase-two
branch
2 times, most recently
from
9167e27 to
3eaa79e
Compare
This was referenced Nov 26, 2024
arianvp
reviewed
Nov 26, 2024
phaer
force-pushed
the
virtualisation-images-phase-two
branch
from
3eaa79e to
e4217e1
Compare
ofborg
bot
added
ofborg-internal-error
zimbatm
approved these changes
Nov 28, 2024
wegank
added
the
12.approvals: 1
adamcstephens
approved these changes
Nov 29, 2024
Contributor
adamcstephens
left a comment
adamcstephens
left a comment
There was a problem hiding this comment.
Reviewing this for the lxc container changes, I think it looks good. Thanks for undertaking this standardization. ❤️
wegank
added
12.approvals: 2
Member
|
Let's merge this before it diverges? |
Contributor
|
lol, of course I just caused it to diverge. I'm happy to merge once rebased. |
phaer
force-pushed
the
virtualisation-images-phase-two
branch
from
e4217e1 to
c78003c
Compare
Member
Author
|
Just rebased, if it still looks good it might be good to merge. I did not test a full rebuild of all image since the rebase yet though and probably won't get to it before Monday. I'll rebase, test & undraft #359345 once this one is done. |
Member
|
Passed nixpkgs-review 👍 |
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses changes in #359326 and #359328 to normalize file names of disk images generated by modules in virtualisation. Please see the PR linked below for a table listing all changed filenames
It was split off #347275 in order to upstream that one in smaller chunks, easier to review, test and (hopefully not) revert.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.