Merged
Conversation
xanderio
added
1.severity: security
xanderio
force-pushed
the
gitlab-17.6.1
branch
from
552932d to
9919a57
Compare
github-actions
bot
added
6.topic: nixos
13 tasks
Member
|
I think we should update gitlab-runner also soon, but it currently still compatible. See #356040 |
leona-ya
approved these changes
Nov 27, 2024
Member
leona-ya
left a comment
leona-ya
left a comment
There was a problem hiding this comment.
This works fine on my instance and also the NixOS Tests succeed.
xanderio
added
the
12.approvals: 1
ofborg
bot
added
10.rebuild-darwin: 1-10
leona-ya
requested changes
Nov 28, 2024
Member
leona-ya
left a comment
leona-ya
left a comment
There was a problem hiding this comment.
We first need to update to 17.5.3, as this is a stop release
wegank
removed
the
12.approvals: 1
xanderio
force-pushed
the
gitlab-17.6.1
branch
from
9919a57 to
f7cd5e0
Compare
xanderio
removed
the
1.severity: security
Member
|
Can you rebase this on master, then it should be ready to merge from my side. |
xanderio
force-pushed
the
gitlab-17.6.1
branch
from
f7cd5e0 to
b7eae8c
Compare
github-actions
bot
removed
6.topic: nixos
leona-ya
approved these changes
Dec 8, 2024
Contributor
|
Successfully created backport PR for |
1 task
Contributor
|
Successfully created backport PR for |
1 task
leona-ya
added
the
1.severity: security
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-359329-to-release-24.05 origin/release-24.05
cd .worktree/backport-359329-to-release-24.05
git switch --create backport-359329-to-release-24.05
git cherry-pick -x b7eae8cb6ad3dcde8c6a9d19e0a81004c94e2a50 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-359329-to-release-24.11 origin/release-24.11
cd .worktree/backport-359329-to-release-24.11
git switch --create backport-359329-to-release-24.11
git cherry-pick -x b7eae8cb6ad3dcde8c6a9d19e0a81004c94e2a50 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: #360160
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.