Merged
Conversation
github-actions
bot
added
6.topic: nixos
13 tasks
phaer
force-pushed
the
virtualisation-images-phase-one
branch
from
176097d to
818d1c6
Compare
13 tasks
A new NixOS module that adds two new options to `system.build`: - imageModules: An attrset mapping image variant names to a list of nixos modules to use when building such images. - images: An attrset mapping image variant names to a nixos instance based on the current config plus variant-specific modules (see `system.build.imageModules` above.
phaer
force-pushed
the
virtualisation-images-phase-one
branch
from
818d1c6 to
08b9155
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two new image-related modules:
nixos/modules/image/file-options.nix defines a re-usable set of options to handle image file names. It will be used in follow-up PRs to normalize the names of disk images generated in nixpkgs.
nixos/modules/image/images.nix adds two new options:
image.modules: An attrset mapping image variant names to a list of nixosmodules to use when building such images.
system.build.images: An attrset mapping image variant names to a nixos instancebased on the current config plus variant-specific modules (see
image.modulesabove.It does not contain any actual modules in images.modules yet, they will follow in upcoming PRs such as in #359339
It was split off #347275 in order to upstream that one in smaller chunks, easier to review, test and (hopefully not) revert.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.