Skip to content

[Backport release-24.11] chromium: resolve ref to rev for blink version string#359139

Merged
emilylange merged 1 commit intorelease-24.11from
backport-358997-to-release-24.11
Nov 26, 2024
Merged

[Backport release-24.11] chromium: resolve ref to rev for blink version string#359139
emilylange merged 1 commit intorelease-24.11from
backport-358997-to-release-24.11

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 25, 2024

Bot-based backport to release-24.11, triggered by a label in #358997.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

This allows us to match the version the binaries use more closely.

For example, chromedriver darwin (binary) reports the following:

~~~bash
chromedriver --version
ChromeDriver 131.0.6778.85 (3d81e41b6f3ac8bcae63b32e8145c9eb0cd60a2d-refs/branch-heads/6778@{#2285})
~~~

while on Linux, where we build chromedriver based on the chromium
derivation from source and control the string ourselves:

~~~bash
chromedriver --version
ChromeDriver 131.0.6778.85 (131.0.6778.85-refs/heads/master@{#0})
~~~

With this commit, the version string now reports:

~~~bash
chromedriver --version
ChromeDriver 131.0.6778.85 (3d81e41b6f3ac8bcae63b32e8145c9eb0cd60a2d-refs/tags/131.0.6778.85@{#0})
~~~

This may seem like a small and unimportant detail, but turns out an
internal function within chromedriver depends on the git hash.

See https://chromium.googlesource.com/chromium/src/+/131.0.6778.85/chrome/test/chromedriver/chrome/browser_info.cc#172

This caused the tests of one package (single-file-cli) that use
selenium with chromium and chromedriver to fail in 24.05.

Only in 24.05, because 24.11 and unstable removed their test dependency
on chromedriver because it wasn't available for aarch64-linux at that
time.

~~~
Running phase: checkPhase
Serving HTTP on 127.0.0.1 port 8000 (http://127.0.0.1:8000/) ...
session not created
from unknown error: unrecognized Blink revision: 131.0.6778.85 URL: http://127.0.0.1:8000
Stack: SessionNotCreatedError: session not created
from unknown error: unrecognized Blink revision: 131.0.6778.85
    at Object.throwDecodedError (/build/source/node_modules/selenium-webdriver/lib/error.js:524:15)
    at parseHttpResponse (/build/source/node_modules/selenium-webdriver/lib/http.js:601:13)
    at Executor.execute (/build/source/node_modules/selenium-webdriver/lib/http.js:529:28)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
~~~

(cherry picked from commit 2a765df)
@emilylange
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359139


x86_64-linux

✅ 38 packages built:
  • aws-azure-login
  • chromedriver
  • chromium
  • chromium.sandbox
  • fast-cli
  • flaresolverr
  • gotenberg
  • grafana-kiosk
  • mermaid-cli
  • mermaid-filter
  • percollate
  • pinnwand
  • pinnwand.dist
  • playwright-test
  • puppeteer-cli
  • python311Packages.great-tables
  • python311Packages.great-tables.dist
  • python311Packages.pytest-playwright
  • python311Packages.pytest-playwright.dist
  • python311Packages.shiny
  • python311Packages.shiny.dist
  • python312Packages.great-tables
  • python312Packages.great-tables.dist
  • python312Packages.pytest-playwright
  • python312Packages.pytest-playwright.dist
  • python312Packages.shiny
  • python312Packages.shiny.dist
  • selendroid
  • selenium-server-standalone
  • sharedown
  • single-file-cli
  • sitespeed-io
  • undetected-chromedriver
  • ungoogled-chromium
  • ungoogled-chromium.sandbox
  • vhs
  • vscode-extensions.yzane.markdown-pdf
  • wayback

@emilylange emilylange merged commit 95802fb into release-24.11 Nov 26, 2024
@emilylange emilylange deleted the backport-358997-to-release-24.11 branch November 26, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant