stdenv: don't discard string context from ContentAddressed derivations#359098
Merged
philiptaron merged 1 commit intoNixOS:masterfrom Nov 26, 2024
Merged
stdenv: don't discard string context from ContentAddressed derivations#359098philiptaron merged 1 commit intoNixOS:masterfrom
philiptaron merged 1 commit intoNixOS:masterfrom
Conversation
Without the change build for packages that use `disallowedReferences`
fails in `contentAddressedByDefault = true` mode:
$ nix build -f. ruby_3_1 --arg config '{ contentAddressedByDefault = true; }'
...
error: derivation contains an illegal reference specifier '/0j3hif3ni7zl5zhlzzr5q2q23z66136mnzp75pyiqp5c72q14im2'
error: 1 dependencies of derivation '/nix/store/39ji7qp225pxvrm8cgvzmyjqsyis2n0h-ruby-3.1.2.drv' failed to build
Original intent of NixOS#211783 was to
avoid pulling in actual derivation for reference scanning purposes.
Unfortunately CA derivations's outputPath are placeholders until they
are instantiated.
Let's restore string context for CA derivations for now.
13 tasks
nix-owners
bot
requested review from
Artturin,
Ericson2314,
RossComputerGuy,
emilazy,
philiptaron and
reckenrode
philiptaron
approved these changes
Nov 25, 2024
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
Let's restore string context for CA derivations for now.
OK.
Contributor
Author
Switched to |
Ericson2314
approved these changes
Nov 25, 2024
gador
approved these changes
Nov 26, 2024
gador
added a commit
to gador/nixpkgs
that referenced
this pull request
Nov 26, 2024
reverts f3d1410 After the merge of NixOS#359098 this workarround for ca-derivations isn't needed anymore. Signed-off-by: Florian Brandes <[email protected]>
gador
added a commit
to gador/nixpkgs
that referenced
this pull request
Nov 26, 2024
This reverts commit 43fccb0. After the merge of NixOS#359098 this workarround for ca-derivations isn't needed anymore. Signed-off-by: Florian Brandes <[email protected]>
gador
added a commit
to gador/nixpkgs
that referenced
this pull request
Nov 26, 2024
reverts 9305ed3 After the merge of NixOS#359098 this workarround for ca-derivations isn't needed anymore. Signed-off-by: Florian Brandes <[email protected]>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change build for packages that use
disallowedReferencesfails incontentAddressedByDefault = truemode:Original intent of #211783 was to avoid pulling in actual derivation for reference scanning purposes.
Unfortunately CA derivations's outputPath are placeholders until they are instantiated.
Let's restore string context for CA derivations for now.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.