Skip to content

prusa-slicer: fix build with GCC 14 and strictDeps#359083

Merged
emilazy merged 1 commit intoNixOS:masterfrom
FliegendeWurst:prusa-fix
Nov 26, 2024
Merged

prusa-slicer: fix build with GCC 14 and strictDeps#359083
emilazy merged 1 commit intoNixOS:masterfrom
FliegendeWurst:prusa-fix

Conversation

@FliegendeWurst
Copy link
Member

@FliegendeWurst FliegendeWurst commented Nov 25, 2024

GCC 14 is in staging and will break the package otherwise.

Upstream: prusa3d/PrusaSlicer#13630

ref. #178468

Things done

@ofborg ofborg bot requested review from hesiod and thorstenweber83 November 26, 2024 15:09
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 26, 2024
@emilazy emilazy merged commit 95823c1 into NixOS:master Nov 26, 2024
@bendlas
Copy link
Contributor

bendlas commented Dec 3, 2024

this broke super-slicer

@FliegendeWurst
Copy link
Member Author

FliegendeWurst commented Dec 3, 2024

Oops, it did. But super-slicer is also broken for unrelated reasons on staging:

/build/source/src/libslic3r/MeshBoolean.cpp:161:16: error: non-const lvalue reference to type 'reference' (aka 'CGAL::SM_Vertex_index') cannot bind to a temporary of type 'reference' (aka 'CGAL::SM_Vertex_index')
  161 |     for (auto &vi : cgalmesh.vertices()) {
      |                ^  ~
/build/source/src/libslic3r/MeshBoolean.cpp:188:12: note: in instantiation of function template specialization 'Slic3r::MeshBoolean::cgal::cgal_to_triangle_mesh<CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epick>>>' requested here
  188 |     return cgal_to_triangle_mesh(cgalmesh.m);
      |            ^
/nix/store/qg5xvm9icynvn84inj4g0z6zq9ibl06b-cgal-5.6.2/include/CGAL/Iterator_range.h:49:5: note: selected 'begin' function with iterator type 'CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epick>>::Index_iterator<CGAL::SM_Vertex_index>'
   49 |   I begin() const
      |     ^
/build/source/src/libslic3r/MeshBoolean.cpp:166:16: error: non-const lvalue reference to type 'reference' (aka 'CGAL::SM_Face_index') cannot bind to a temporary of type 'reference' (aka 'CGAL::SM_Face_index')
  166 |     for (auto &face : cgalmesh.faces()) {
      |                ^    ~
/nix/store/qg5xvm9icynvn84inj4g0z6zq9ibl06b-cgal-5.6.2/include/CGAL/Iterator_range.h:49:5: note: selected 'begin' function with iterator type 'CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epick>>::Index_iterator<CGAL::SM_Face_index>'
   49 |   I begin() const
      |     ^
3 warnings and 2 errors generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants