superlu: 5.2.1 -> 7.0.0; openmolcas: unpin Boost#359050
Merged
markuskowa merged 2 commits intoNixOS:stagingfrom Nov 30, 2024
Merged
superlu: 5.2.1 -> 7.0.0; openmolcas: unpin Boost#359050markuskowa merged 2 commits intoNixOS:stagingfrom
markuskowa merged 2 commits intoNixOS:stagingfrom
Conversation
Includes fixes for GCC 14. Also addresses non‐free code already removed by Debian. If there’s demand for this functionality it could be re‐added under a flag.
ofborg
bot
added
10.rebuild-darwin: 11-100
markuskowa
approved these changes
Nov 27, 2024
Member
markuskowa
left a comment
markuskowa
left a comment
There was a problem hiding this comment.
openmolcas LGTM. I am just a bit confused here: how is openmolcas connected to superlu?
cc @sheepforce
Member
I think it isn't: $ nix why-depends nixpkgs/master#openmolcas nixpkgs/master#superlu
this path will be fetched (0.20 MiB download, 0.63 MiB unpacked):
/nix/store/df9zjr9xbip7qsbs4icy6wlmb5nsjwiv-superlu-5.2.1
'flake:nixpkgs/master#openmolcas' does not depend on 'flake:nixpkgs/master#superlu'Otherwise unpinning boost in OpenMolcas is certainly a good idea :) |
Member
Author
|
It’s a build‐time dependency, so I had to fix Whether that’s sensible or not, I don’t know – I confess that I’m doing a tree‐wide clean‐up and couldn’t accurately describe exactly what this software does :) |
wegank
added
12.approvals: 1
13 tasks
Contributor
|
for whatever reason after the update to superlu darwin is segfaulting running tests. not linking to accelerate and using the bias package fixes -- #367110 [edit] superlu is using the single precision interface |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes fixes for GCC 14. Also addresses non‐free code already removed by Debian. If there’s demand for this functionality it could be re‐added under a flag.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.