Skip to content

gpxlab: add symlink to binary on darwin, migrate to by-name#358684

Merged
sikmir merged 2 commits intoNixOS:masterfrom
sikmir:gpxlab
Dec 6, 2024
Merged

gpxlab: add symlink to binary on darwin, migrate to by-name#358684
sikmir merged 2 commits intoNixOS:masterfrom
sikmir:gpxlab

Conversation

@sikmir
Copy link
Member

@sikmir sikmir commented Nov 24, 2024

  • Fix nix run nixpkgs#gpxlab on darwin:
error: unable to execute '/nix/store/35cjag1zklhjb1lfgghdngc4y973bdyk-gpxlab-0.7.0/bin/gpxlab': No such file or directory

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 25, 2024
@sikmir
Copy link
Member Author

sikmir commented Dec 6, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 358684

x86_64-darwin

✅ 1 package built:
  • gpxlab

@sikmir sikmir merged commit 08c3c0c into NixOS:master Dec 6, 2024
@sikmir sikmir deleted the gpxlab branch December 6, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Qt mkDerivation is slightly broken, redundant and should be deprecated

1 participant

@sikmir