Skip to content

OWNERS: Add azuwis to .github/workflows#358165

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
azuwis:push-komvkypvlquo
Nov 22, 2024
Merged

OWNERS: Add azuwis to .github/workflows#358165
Mic92 merged 1 commit intoNixOS:masterfrom
azuwis:push-komvkypvlquo

Conversation

@azuwis
Copy link
Contributor

@azuwis azuwis commented Nov 22, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Nov 22, 2024
@azuwis azuwis mentioned this pull request Nov 22, 2024
Merged
@Mic92
Copy link
Member

Mic92 commented Nov 22, 2024

@infinisil please add azuwis to the nixpkgs maintainer team.

@infinisil
Copy link
Member

infinisil commented Nov 22, 2024

Can't do that, the easiest way would be to create a separate PR to add an entry to maintainer-list.nix, which when merged should send an automated invite to the Nixpkgs maintainers team :)

@Mic92
Copy link
Member

Mic92 commented Nov 22, 2024

Ok. That's what we need than.

@azuwis
Copy link
Contributor Author

azuwis commented Nov 22, 2024

Can't do that, the easiest way would be to create a separate PR to add an entry to maintainer-list.nix, which when merged should send an automated invite to the Nixpkgs maintainers team :)

Em, I was already in maintainer-list.nix

nixpkgs/maintainers/maintainer-list.nix

Line 2314 in 9069a28

azuwis = {

@azuwis
Copy link
Contributor Author

azuwis commented Nov 22, 2024

Em, I was already in maintainer-list.nix

It was added at Feb 10 2022, I've just checked, did not find any Github invitation email.

@Mic92
Copy link
Member

Mic92 commented Nov 22, 2024

@zimbatm can you send a new invite?

@zimbatm
Copy link
Member

zimbatm commented Nov 22, 2024

@azuwis sent an invite

@azuwis
Copy link
Contributor Author

azuwis commented Nov 22, 2024

Force push to trigger CI, it passes now.

@Mic92 Mic92 merged commit 9d9c9b1 into NixOS:master Nov 22, 2024
@azuwis azuwis deleted the push-komvkypvlquo branch April 1, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infinisil infinisil Awaiting requested review from infinisil

@philiptaron philiptaron Awaiting requested review from philiptaron

Assignees

No one assigned

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@azuwis @Mic92 @infinisil @zimbatm