add actionlint script and fix linting errors#358087
Merged
Mic92 merged 3 commits intoNixOS:masterfrom Nov 22, 2024
Merged
Conversation
github-actions
bot
added
6.topic: policy discussion
13 tasks
nix-owners
bot
requested review from
LeSuisse,
infinisil,
mweinelt,
risicle and
zowoq
azuwis
suggested changes
Nov 22, 2024
azuwis
reviewed
Nov 22, 2024
Mic92
force-pushed
the
actionlint
branch
2 times, most recently
from
0b19dd0 to
57540a2
Compare
azuwis
reviewed
Nov 22, 2024
Update .github/workflows/check-nixf-tidy.yml Co-authored-by: Zhong Jianxin <[email protected]>
azuwis
approved these changes
Nov 22, 2024
Member
|
@azuwis Would you mind also being registered as |
Contributor
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it might be worth adding this in future as a separate CI step, it seems overkill given how often it would need to run on nixpkgs (could be circumvented by filtering, but it would still add a check line in each PR). This script is also easier to run local.