Skip to content

readline: add library symlinks on OpenBSD#358074

Merged
Ericson2314 merged 1 commit intoNixOS:stagingfrom
rhelmot:readline-openbsd
Feb 22, 2025
Merged

readline: add library symlinks on OpenBSD#358074
Ericson2314 merged 1 commit intoNixOS:stagingfrom
rhelmot:readline-openbsd

Conversation

@rhelmot
Copy link
Contributor

@rhelmot rhelmot commented Nov 22, 2024

This install error is caused by a very old libtool. We can't autoreconfHook this package, so this is the best we've got!

Before:

$ ll /nix/store/q4xfivjrnjhshp0khjy66nq5ljjdmfv1-readline-x86_64-unknown-openbsd-8.2p13/lib
total 448K
-r--r--r-- 1 root root  48K Dec 31  1969 libhistory.so.8.2
-r--r--r-- 1 root root 399K Dec 31  1969 libreadline.so.8.2

After:

$ ll /nix/store/q9986qvm5jhnlxckp972cmhdgp5v52km-readline-x86_64-unknown-openbsd-8.2p13/lib
total 448K
lrwxrwxrwx 1 root root   17 Dec 31  1969 libhistory.so -> libhistory.so.8.2
-r--r--r-- 1 root root  48K Dec 31  1969 libhistory.so.8.2
lrwxrwxrwx 1 root root   18 Dec 31  1969 libreadline.so -> libreadline.so.8.2
-r--r--r-- 1 root root 399K Dec 31  1969 libreadline.so.8.2

Things done

  • Built on platform(s)
    • x86_64-linux (openbsd cross)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@rhelmot rhelmot changed the title readline: add library symlinks readline: add library symlinks on OpenBSD Nov 22, 2024
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Nov 23, 2024
@ofborg ofborg bot requested a review from dtzWill November 23, 2024 01:12
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 23, 2024
@rhelmot rhelmot added the 6.topic: bsd Running or building packages on BSD label Nov 30, 2024
@Ericson2314
Copy link
Member

I think this message is better a code comment than a commit message.

@github-actions github-actions bot removed the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Feb 22, 2025
@Ericson2314 Ericson2314 merged commit 10315b6 into NixOS:staging Feb 22, 2025
25 of 27 checks passed
@Ericson2314 Ericson2314 deleted the readline-openbsd branch February 22, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: bsd Running or building packages on BSD 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants