Skip to content

ncurses: provide openbsd version number in host triple#358066

Merged
Ericson2314 merged 1 commit intoNixOS:stagingfrom
rhelmot:openbsd-ncurses
Feb 22, 2025
Merged

ncurses: provide openbsd version number in host triple#358066
Ericson2314 merged 1 commit intoNixOS:stagingfrom
rhelmot:openbsd-ncurses

Conversation

@rhelmot
Copy link
Contributor

@rhelmot rhelmot commented Nov 22, 2024

Unversioned openbsd will trip a configure branch that assumes your openbsd is from the 90s. This leads to a truly awful compiler/linker configuration. No, autoreconfHook doesn't work.

Things done

  • Built on platform(s)
    • x86_64-linux (openbsd cross)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 23, 2024
@rhelmot rhelmot added the 6.topic: bsd Running or building packages on BSD label Nov 30, 2024
@rhelmot rhelmot mentioned this pull request Jan 16, 2025
14 tasks
@Ericson2314
Copy link
Member

I think this commit message is better as a code-comment. One of the two items can get the comment, and the other can have a "see ... above ..." / "see ... below ...."

@github-actions github-actions bot removed the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Feb 22, 2025
@Ericson2314 Ericson2314 merged commit c22f12e into NixOS:staging Feb 22, 2025
25 of 27 checks passed
@Ericson2314 Ericson2314 deleted the openbsd-ncurses branch February 22, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: bsd Running or building packages on BSD 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants