workflows/eval: Minor fixes, ensure the correct commit is checked out#357965
Merged
Mic92 merged 2 commits intoNixOS:masterfrom Nov 21, 2024
Merged
workflows/eval: Minor fixes, ensure the correct commit is checked out#357965Mic92 merged 2 commits intoNixOS:masterfrom
Mic92 merged 2 commits intoNixOS:masterfrom
Conversation
- `env.mergedSha` is empty, so it checked out the master version by default - The process step used `needs.attrs.outputs.mergedSha`, but apparently that's empty unless `attrs` is declared as a `needs`, even though `outputs` implicitly depends on `attrs`
github-actions
bot
added
6.topic: policy discussion
2 tasks
nix-owners
bot
requested review from
LeSuisse,
Mic92,
mweinelt,
philiptaron,
risicle and
zowoq
1 task
Contributor
|
Actually actionlint found this: But i was not quite familiar with cross job variable passing, and ignored it. Maybe we can add an actionlint workflow? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
env.mergedShais empty, so it checked out the master version by defaultneeds.attrs.outputs.mergedSha, but apparently that's empty unlessattrsis declared as aneeds, even thoughoutputsimplicitly depends onattrsThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)This work is funded by Tweag and Antithesis ✨
Add a 👍 reaction to pull requests you find important.