Skip to content

nodejs_23: 23.2.0 -> 23.5.0#357699

Merged
dasJ merged 1 commit intoNixOS:stagingfrom
aduh95:nodejs_23
Dec 25, 2024
Merged

nodejs_23: 23.2.0 -> 23.5.0#357699
dasJ merged 1 commit intoNixOS:stagingfrom
aduh95:nodejs_23

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 20, 2024 •
edited
Loading

Things done

https://github.com/nodejs/node/releases/tag/v23.5.0

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment label Nov 20, 2024
@emilazy
Copy link
Member

emilazy commented Nov 21, 2024 •
edited
Loading

Can we point this at staging instead? Due to 982e3fc it keeps causing conflicts that need to be resolved manually. (The backport can still be to the release branch.)

@aduh95 aduh95 changed the base branch from master to staging November 21, 2024 08:26
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 21, 2024
@emilazy
Copy link
Member

emilazy commented Nov 22, 2024

ofborg seems unhappy.

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 25, 2024
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 26, 2024 •
edited
Loading

Removing https://github.com/NixOS/nixpkgs/labels/backport%20release%2D24%2E11 as the revert commit won't apply to 24.11

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@aduh95 aduh95 changed the title nodejs_23: 23.2.0 -> 23.3.0 nodejs_23: 23.2.0 -> 23.4.0 Dec 10, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 11, 2024
@github-actions github-actions bot removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Dec 19, 2024
@aduh95 aduh95 changed the title nodejs_23: 23.2.0 -> 23.4.0 nodejs_23: 23.2.0 -> 23.5.0 Dec 19, 2024
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Dec 20, 2024
@ofborg ofborg bot requested a review from np December 20, 2024 20:11
@ofborg ofborg bot added the 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. label Dec 20, 2024
@ofborg ofborg bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Dec 20, 2024
@github-actions github-actions bot removed 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Dec 21, 2024
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Dec 22, 2024
@github-actions github-actions bot removed 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Dec 24, 2024
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Dec 25, 2024
@dasJ dasJ merged commit 2b8df76 into NixOS:staging Dec 25, 2024
4 of 5 checks passed
@aduh95 aduh95 deleted the nodejs_23 branch December 26, 2024 00:32
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 26, 2024

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-357699-to-release-24.11 origin/release-24.11
cd .worktree/backport-357699-to-release-24.11
git switch --create backport-357699-to-release-24.11
git cherry-pick -x 2b8df7696923fa204511df546be1256a8b9cfa1f

aduh95 added a commit to aduh95/nixpkgs that referenced this pull request Dec 26, 2024
@aduh95
nodejs_23: 23.2.0 -> 23.5.0 (NixOS#357699)
ee9287e 
(cherry picked from commit 2b8df76)
emilazy pushed a commit to emilazy/nixpkgs that referenced this pull request Jan 5, 2025
@aduh95 @emilazy
nodejs_23: 23.2.0 -> 23.5.0 (NixOS#357699)
0f893f1 
(cherry picked from commit 2b8df76)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@np np Awaiting requested review from np

Assignees

No one assigned

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95 @emilazy @dasJ @wegank