Skip to content

xcbuild: const can't desctruct. fix build#357472

Merged
emilazy merged 1 commit intoNixOS:llvm-19from
paparodeo:no-const-destructor
Nov 20, 2024
Merged

xcbuild: const can't desctruct. fix build#357472
emilazy merged 1 commit intoNixOS:llvm-19from
paparodeo:no-const-destructor

Conversation

@paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Nov 20, 2024 •
edited
Loading

build failed on clang-19
fixes 82a00b7

nix/store/6dg0y40g03sw8clpvwhmp9isivcjq4c8-libcxx-19.1.4-dev/include/c++/v1/__memory/allocator_traits.h:378:17: 
error: static assertion failed due to requirement 'is_same<std::allocator<const std::string>, std::allocator<int>>::value': [allocator.requirements] states that rebinding an allocator to the same type should result in the original allocator
  378 |   static_assert(is_same<_Alloc, __rebind_alloc<_Traits, typename _Traits::value_type> >::value,
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

testing: just built as part of stdenv while testing clang-19.1.4 on llvm-19 branch

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy

@paparodeo
xcbuild: const can't desctruct. fix build
ab58983 
build failed on clang-19
fixes 82a00b7
@paparodeo paparodeo changed the base branch from staging to llvm-19 November 20, 2024 05:33
emilazy
emilazy approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://clang.llvm.org/extra/clang-tidy/checks/portability/std-allocator-const.html confirms that this is a non‐portable pattern and that the replacement is correct.

@emilazy emilazy merged commit 268c6e4 into NixOS:llvm-19 Nov 20, 2024
@paparodeo paparodeo deleted the no-const-destructor branch November 20, 2024 05:36
@paparodeo
Copy link
Contributor Author

paparodeo commented Nov 20, 2024

could this back port to staging-24.11? thx

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Successfully created backport PR for staging-24.11:

@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilazy emilazy emilazy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paparodeo @emilazy