Skip to content

Unbreak haskellPackages.monomer-hagrid#356936

Closed
lzszt wants to merge 1 commit intoNixOS:masterfrom
lzszt:unbreak-monomer-hagrid
Closed

Unbreak haskellPackages.monomer-hagrid#356936
lzszt wants to merge 1 commit intoNixOS:masterfrom
lzszt:unbreak-monomer-hagrid

Conversation

@lzszt
Copy link
Contributor

@lzszt lzszt commented Nov 18, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Nov 18, 2024
@maralorn
Copy link
Member

maralorn commented Nov 18, 2024 •
edited
Loading

Thank you for your contribution. A few remarks.

You edited an autogenerated file. If you want to target your PR at master you have to

a) remove the package from the file broken.yaml
b) run the maintainers/scripts/haskell/regenerate-hackage-packages.sh script
c) commit those changes.

Also according to our contribution guide lines please permute your commit message so that it starts with haskellPackages.monomer-hagrid:

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 19, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@sternenseemann sternenseemann mentioned this pull request Apr 22, 2025
Merged
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 25, 2025
@lzszt lzszt closed this Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lzszt @maralorn @wegank