treewide: remove deprecations up until 24.11 (staging part)#356735
Merged
emilazy merged 2 commits intoNixOS:stagingfrom Nov 22, 2024
Merged
treewide: remove deprecations up until 24.11 (staging part)#356735emilazy merged 2 commits intoNixOS:stagingfrom
emilazy merged 2 commits intoNixOS:stagingfrom
Conversation
23.05 is not supported anymore.
github-actions
bot
added
6.topic: nixos
nix-owners
bot
requested review from
Mic92,
kalbasit,
katexochen,
tfc and
zowoq
Contributor
|
Please drop the Go commit, args have already been removed for |
Scheduled for removal in 24.11, so let's follow through. Added in NixOS#291544.
wolfgangwalther
force-pushed
the
remove-deprecations-for-2411-staging
branch
from
61594f9 to
71306e6
Compare
Contributor
Author
Thanks for the heads-up. In fact, half of my commit was already gone by rebasing on staging (modules part) - didn't even notice. Dropped! |
github-actions
bot
removed
the
6.topic: golang
ofborg
bot
added
10.rebuild-darwin: 11-100
emilazy
approved these changes
Nov 22, 2024
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #356732, but with changes causing a few rebuilds.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.