Skip to content

Revert "systemd: revert boot-breaking systemd-boot change"#356686

Merged
emilazy merged 1 commit intoNixOS:stagingfrom
emilazy:push-wmrpympltzmz
Nov 17, 2024
Merged

Revert "systemd: revert boot-breaking systemd-boot change"#356686
emilazy merged 1 commit intoNixOS:stagingfrom
emilazy:push-wmrpympltzmz

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Nov 17, 2024

This was incorporated upstream in v256.8 as systemd/systemd@a9d9db7.

This reverts commit 63ce466.

Fixes: 6fc6e7b

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This was incorporated upstream in v256.8 as
<systemd/systemd@a9d9db7>.

This reverts commit 63ce466.

Fixes: 6fc6e7b
@github-actions github-actions bot added the 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. label Nov 17, 2024
@emilazy emilazy marked this pull request as ready for review November 17, 2024 12:32
@nix-owners nix-owners bot requested review from aanderse, arianvp and flokli November 17, 2024 12:34
@emilazy
Copy link
Member Author

emilazy commented Nov 17, 2024

Built github:NixOS/nixpkgs/pull/356686/merge#systemd on aarch64-linux. I’m going to merge proactively as the build is just 100% broken on staging right now, which makes it a pain to test merges. cc @NixOS/systemd

@emilazy emilazy merged commit 9550374 into NixOS:staging Nov 17, 2024
@emilazy emilazy deleted the push-wmrpympltzmz branch November 17, 2024 12:34
@emilazy
Copy link
Member Author

emilazy commented Nov 17, 2024

Gah – so it was correct to revert this patch as it would fail to apply, but it turns out that the systemdMinimal failure is from another patch that isn’t caught by the systemd build. So I’ll look into that too…

Edit: No, it’s the same patch and it was just a classic Nix tarball TTL issue.

@github-actions
Copy link
Contributor

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-356686-to-release-24.11 origin/release-24.11
cd .worktree/backport-356686-to-release-24.11
git switch --create backport-356686-to-release-24.11
git cherry-pick -x 19853b79530b5c99e5e1412aaf9721e0ec3b70bb

@github-actions
Copy link
Contributor

Successfully created backport PR for staging-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: systemd Software suite that provides an array of system components for Linux operating systems.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants