Skip to content

systemd: 256.7 -> 256.8#356365

Merged
ElvishJerricco merged 1 commit intoNixOS:stagingfrom
Princemachiavelli:jhoffer/systemd_256_8
Nov 16, 2024
Merged

systemd: 256.7 -> 256.8#356365
ElvishJerricco merged 1 commit intoNixOS:stagingfrom
Princemachiavelli:jhoffer/systemd_256_8

Conversation

@Princemachiavelli
Copy link
Contributor

@Princemachiavelli Princemachiavelli commented Nov 16, 2024

Changes

systemd/systemd@v256.7...v256.8

Tests

The switchTest, systemd-journal, and systemd-journal-upload tests all pass. The systemd-journal-gateway test is already broken due to #297870.

@github-actions github-actions bot added the 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. label Nov 16, 2024
@Princemachiavelli Princemachiavelli changed the base branch from master to staging November 16, 2024 05:07
@ofborg ofborg bot requested a review from kloenk November 16, 2024 17:46
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 16, 2024
@ElvishJerricco ElvishJerricco merged commit dc2fbd5 into NixOS:staging Nov 16, 2024
@github-actions
Copy link
Contributor

Successfully created backport PR for staging-24.11:

@trofi
Copy link
Contributor

trofi commented Nov 17, 2024

git bisect says this PR broke patch application in staging for systemdMinimal as:

$ nix build --no-link -f. systemdMinimal
...
systemd-minimal> applying patch /nix/store/r7s8r0nv2n8nw9hw7s275va27g2lgx8b-0019-Revert-boot-Make-initrd_prepare-semantically-equival.patch
systemd-minimal> patching file src/boot/efi/boot.c
systemd-minimal> Hunk #4 FAILED at 2292.
systemd-minimal> Hunk #5 succeeded at 2382 (offset 9 lines).
systemd-minimal> Hunk #6 succeeded at 2402 (offset 9 lines).
systemd-minimal> 1 out of 6 hunks FAILED -- saving rejects to file src/boot/efi/boot.c.rej

@emilazy
Copy link
Member

emilazy commented Nov 17, 2024

@trofi got here 5 minutes before me 😅

I assume the failing patch is #355290.

@emilazy
Copy link
Member

emilazy commented Nov 17, 2024

#356686

The PR for the now‐upstreamed patch was merged some five days before this PR was opened. I’m a little concerned that we merged this without anyone trying to build the merge despite there having been changes to systemd in staging since the parent of the commit. Admittedly GitHub should surface such things better. (Edit: and I’m not trying to point fingers here, I’ve done some sloppy stuff lately too – just seems like a process problem.)

@ElvishJerricco
Copy link
Contributor

This is my bad. I didn't test the merge like I should have. I didn't know that other patch had been fixed upstream, let alone backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants