[Backport release-24.11] nixos-render-docs: init redirects system#356261
Closed
github-actions[bot] wants to merge 2 commits intorelease-24.11from
Closed
[Backport release-24.11] nixos-render-docs: init redirects system#356261github-actions[bot] wants to merge 2 commits intorelease-24.11from
github-actions[bot] wants to merge 2 commits intorelease-24.11from
Conversation
Co-authored-by: Valentin Gagarin <[email protected]> (cherry picked from commit 5b8a714)
fricklerhandwerk
approved these changes
Nov 15, 2024
wegank
added
the
12.approvals: 1
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
Considering this change broke some downstream consumers (e.g.: Home-Manager), I strongly recommend us to not backport this so late in the release cycle. Edit: even the CI is broken for this change, this is not a good sign. |
Contributor
|
@thiagokokada thanks for pointing out the Home Manager issue. We'll sort that out first and then see about backporting. |
13 tasks
Contributor
|
Is the plan to still backport this? |
Member
|
This PR doesn't meet the backport criteria in its current state, according to Thiago's comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-24.11, triggered by a label in #353513.