Skip to content

[24.11] postgresql: 16.4 -> 16.5#356152

Merged
Ma27 merged 2 commits intoNixOS:staging-24.11from
Ma27:24.11-backport-pg16
Nov 15, 2024
Merged

[24.11] postgresql: 16.4 -> 16.5#356152
Ma27 merged 2 commits intoNixOS:staging-24.11from
Ma27:24.11-backport-pg16

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 15, 2024

Release Notes:
https://www.postgresql.org/about/news/postgresql-171-165-159-1414-1317-and-1221-released-2955/

(cherry picked from commit 797b544)

Backport PR #355974

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Ma27 Ma27 requested a review from wolfgangwalther November 15, 2024 11:37
@Ma27 Ma27 added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 15, 2024
This replaces `writeShellApplication` with `writeShellScriptBin` that
doesn't perform a shellcheck. This makes it way easier to build
postgresql on staging since GHC is super slow to build, even with pretty
powerful machines.

Also Haskell updates are currently merged straight into master which
means that postgresql and all reverse dependencies require a rebuild on
master then[1].

[1] NixOS#354270 (comment)

(cherry picked from commit 4cd083a)
@Ma27
Copy link
Member Author

Ma27 commented Nov 15, 2024

OK I figured we can also backport the Haskell dependency stuff given that this has to go through staging anyways.

@Ma27 Ma27 marked this pull request as ready for review November 15, 2024 11:58
@nix-owners nix-owners bot requested a review from thoughtpolice November 15, 2024 11:59
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 15, 2024
@Ma27 Ma27 merged commit 7e98eab into NixOS:staging-24.11 Nov 15, 2024
@Ma27 Ma27 deleted the 24.11-backport-pg16 branch November 15, 2024 22:58
@Ma27
Copy link
Member Author

Ma27 commented Nov 15, 2024

@wolfgangwalther will do the backport to 24.05 of that tomorrow afternoon.

@ofborg ofborg bot requested review from globin, ivan and wolfgangwalther November 15, 2024 23:04
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants