Skip to content

openjpeg: fix eval#356116

Merged
emilazy merged 1 commit intoNixOS:llvm-19from
paparodeo:pylibjpeg-fix-eval
Nov 15, 2024
Merged

openjpeg: fix eval#356116
emilazy merged 1 commit intoNixOS:llvm-19from
paparodeo:pylibjpeg-fix-eval

Conversation

@paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Nov 15, 2024

python3Packages.pylibjpeg-openjpeg tries to access openjpeg.src which was changed to srcs in 1f9a1d0. Change it back.

testing: nix eval -f . python3Packages.pylibjpeg-openjpeg

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 15, 2024
@paparodeo paparodeo marked this pull request as draft November 15, 2024 09:45
@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 15, 2024
@paparodeo paparodeo changed the title python3Packages.pylibjpeg-openjpeg: fix eval openjpeg: fix eval Nov 15, 2024
@paparodeo paparodeo marked this pull request as ready for review November 15, 2024 09:52
@paparodeo paparodeo marked this pull request as draft November 15, 2024 10:03
@paparodeo paparodeo marked this pull request as ready for review November 15, 2024 10:05
@paparodeo paparodeo marked this pull request as draft November 15, 2024 10:20
python3Packages.pylibjpeg-openjpeg tries to access openjpeg.src which
was changed to srcs in 1f9a1d0. Change
it back.
@paparodeo paparodeo marked this pull request as ready for review November 15, 2024 10:22
@emilazy emilazy merged commit 66ba251 into NixOS:llvm-19 Nov 15, 2024
@paparodeo paparodeo deleted the pylibjpeg-fix-eval branch November 15, 2024 16:13
emilazy added a commit to emilazy/nixpkgs that referenced this pull request Nov 16, 2024
emilazy added a commit that referenced this pull request Nov 17, 2024
emilazy added a commit to emilazy/nixpkgs that referenced this pull request Nov 18, 2024
emilazy added a commit that referenced this pull request Nov 18, 2024
emilazy added a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants