Conversation
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Sorry about the miscommunication on the earlier PR, and thanks for sending this. Since it’s identical to the previous package with a different JDK version, I’m happy to trust your testing.
However, there is a mismatch between the pkgs/by-name path and the attribute. This will result in a bisq attribute that uses the default openjdk, which is presumably not what you want. I recommend either renaming the directory to bisq2, or removing the line from all-packages.nix entirely and using (jdk23.override …) directly in the package definition. I apologize that the reviewer didn’t catch this on the previous PR.
ofborg
bot
added
8.has: package (new)
ofborg
bot
added
the
10.rebuild-linux: 1
|
BTW, 24.11 is already branched off; I can backport this if you want it to make the upcoming stable release. |
|
Yes, I'd like to make it to the 24.11 release. Thank you. |
|
Successfully created backport PR for |
3 participants
This PR adds Bisq 2, a decentralized bitcoin exchange that allows anyone to buy and sell bitcoin in exchange for national currencies or other cryptocurrencies.
This is a continuation of #347160, which was rolled back on #352550
The package now uses JDK 23.
Verification
It is customary to verify the downloaded Bisq application by importing upstream's GPG key and verifying the signature of the downloaded package.
This Nix package includes build-time verification of the downloaded Debian package. This is to give users of this package a greater level of confirmation --compared to verification by the maintainer, (me)-- that the package has been signed by upstream. In short, if this package builds, then it's also verified.
QR code scanning
There's a bundled "webcam app" which is used for webcam access to scan QR codes. This app does not work on NixOS due to bundled libraries which need to be patchelf'ed. I already made two attempts to add support for this "webcam app" and failed. I will not be making another attempt.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.