Skip to content

haskellPackages.immortal: disable flaky tests on darwin#355766

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
sternenseemann:immortal-no-tests
Nov 14, 2024
Merged

haskellPackages.immortal: disable flaky tests on darwin#355766
vcunat merged 1 commit intoNixOS:staging-nextfrom
sternenseemann:immortal-no-tests

Conversation

@sternenseemann
Copy link
Member

Note that I coaxed the tests into succeeding now by restarting a few more times, so not urgent anymore.

It took 5 tries in https://hydra.nixos.org/eval/1809897 for the tests to succeed on x86_64 and aarch64 darwin, respectively.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Nov 13, 2024
@nix-owners nix-owners bot requested a review from maralorn November 13, 2024 22:46
@vcunat vcunat merged commit 3a06a0e into NixOS:staging-next Nov 14, 2024
@sternenseemann sternenseemann deleted the immortal-no-tests branch November 14, 2024 10:45
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 4, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants