Skip to content

python3Packages.python-mapnik: mark broken#355713

Merged
ulrikstrid merged 1 commit intoNixOS:masterfrom
superherointj:python3Packages.python-mapnik-fix-build
Nov 26, 2024
Merged

python3Packages.python-mapnik: mark broken#355713
ulrikstrid merged 1 commit intoNixOS:masterfrom
superherointj:python3Packages.python-mapnik-fix-build

Conversation

@superherointj
Copy link
Contributor

@superherointj superherointj commented Nov 13, 2024

Fixes build. (Skipping "test_raster_warping")

Mark broken. (Avoids false positives)

Unmaintained package.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 13, 2024
@superherointj
Copy link
Contributor Author

Review @paparodeo ?

@paparodeo
Copy link
Contributor

not sure if ignoring the test failure is the right thing to do here. updating the package perhaps tho the patch(s) need to get fixed.

@superherointj
Copy link
Contributor Author

superherointj commented Nov 13, 2024

I don't want to maintain this package. I'm doing minimal change to avoid false positives in builds. In this regard, I think this change is fine.

I cannot properly test the upgrade of this package since I have no context of it.

@paparodeo
Copy link
Contributor

marking it broken makes more sense to me. it seems like it needs to be somewhat in sync with mapnik. I tried to just update it but it failed to compile and all the things seemed to be at synced versions.

anyway, I also don't care about the package but think that marking broken is preferable to marking a possibly broken package as working.

@superherointj superherointj force-pushed the python3Packages.python-mapnik-fix-build branch from 8775bd7 to 5647888 Compare November 13, 2024 23:10
@superherointj superherointj changed the title python3Packages.python-mapnik: fix build python3Packages.python-mapnik: mark broken Nov 13, 2024
@superherointj
Copy link
Contributor Author

superherointj commented Nov 13, 2024

@paparodeo I agree the sensible thing to do is to mark broken. But unfortunately, many people at nixpkgs force contributors to fix packages which they don't understand or have context of. I think, reporting a false positive build dependency as broken should have a low barrier, and contributors should not be forced into fixing things that do not concern them. And this should not be frowned upon.

I actually wanted to remove all these unmaintained packages. Either someone steps up to maintain, or these packages should be made inactive (since they are broken).

@superherointj
Copy link
Contributor Author

superherointj commented Nov 13, 2024

CC @hummeltech @Dettorer

Would you have an interest in this package?
(Found your handles from Git History that bumped/altered this package locally.)

@superherointj
Copy link
Contributor Author

Maybe @NixOS/geospatial ?

@hummeltech
Copy link
Contributor

Yeah, marking is broken is fine by me. I don't really use it, so I might not be the best maintainer, but it looks like there might soon be a new release.
mapnik/python-mapnik@10315a6

@paparodeo
Copy link
Contributor

paparodeo commented Nov 14, 2024

Yeah, marking is broken is fine by me. I don't really use it, so I might not be the best maintainer, but it looks like there might soon be a new release. mapnik/python-mapnik@10315a6

the new release doesn't compile (and it doesn't seem they ever lose the beta suffix).

@Dettorer
Copy link
Contributor

Dettorer commented Nov 14, 2024

CC @hummeltech @Dettorer

Would you have an interest in this package? (Found your handles from Git History that bumped/altered this package locally.)

In principle why not, but same as hammeltech, I don't really us it these days (I did for a small personal project that's on hiatus, like personal projects tend to end up). And more importantly, I really don't have the time right know, but I'll see if this still needs a nixpkgs maintainer once my schedule clears up a bit (in a few months hopefully).

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 14, 2024
@autra
Copy link
Contributor

autra commented Nov 14, 2024

I also think we should mark this as broken:

  • upstream is currently undergoing a big rewrite, at least in the build process
  • they don't give us a clear release compatible with the current mapnik version in nixpkgs. We are doing guessworks.

I've tried fixing it, but didn't manage to, probably because I don't have the correct commit. As I'm not using it either, I won't be spending more time on this. For those interested, here is my wip.

I think we can also add the geospatial team as maintainers. If someone fixes it, they'd have someone to ping for the review.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 14, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 14, 2024
@tomodachi94 tomodachi94 linked an issue Nov 20, 2024 that may be closed by this pull request
@ulrikstrid ulrikstrid merged commit e15fcb1 into NixOS:master Nov 26, 2024
@github-actions
Copy link
Contributor

Successfully created backport PR for staging-24.11:

@imincik
Copy link
Contributor

imincik commented Nov 28, 2024

I also think we should mark this as broken:

  • upstream is currently undergoing a big rewrite, at least in the build process
  • they don't give us a clear release compatible with the current mapnik version in nixpkgs. We are doing guessworks.

I've tried fixing it, but didn't manage to, probably because I don't have the correct commit. As I'm not using it either, I won't be spending more time on this. For those interested, here is my wip.

I think we can also add the geospatial team as maintainers. If someone fixes it, they'd have someone to ping for the review.

Thanks for investigating. I agree with you .

@superherointj superherointj deleted the python3Packages.python-mapnik-fix-build branch November 28, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: python3Packages.python-mapnik

8 participants