openjpeg: don't use vendored libs in tests#355345
openjpeg: don't use vendored libs in tests#355345emilazy merged 1 commit intoNixOS:llvm-19from paparodeo:openjpeg-test-without-3rd-party-libs
Conversation
ofborg
bot
added
10.rebuild-darwin: 501+
|
(Going to try to spend a little time to see if it’s possible to just make CTest work normally before merging this.) |
I'm not super confident that the test are actually passing -- the build succeeds but I think they are just silently failing. it seems that there is a required data repo we are not downloading: https://github.com/uclouvain/openjpeg-data. downloading the data and then adding to the building a "successful" test run then looking in the |
|
Aha. So the primary service the Travis CI CMake file is providing to us is to swallow all the errors? Maybe we should just leave a comment that the data repository needs downloading for the tests and some of them fail, and remove the current code and disable them entirely for now until someone else gets them working. Or we could disable the failing 10%, I guess. |
it's weird -- like when it couldn't compile stuff due to the vendored zlib it didn't report the compile error, ran the tests, and then failed -- which is what this PR aimed to fix ( and does). but, yeah, it seems like the test failures aren't getting reported. feel like I should've just left the tests disabled. they already were disabled for aarch64 and only were running on x64 darwin and linux. even with 10% failing that's like 140 tests that would need to be disabled. maybe there is a regex that matches... |
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Seems reasonable. Scary to disable that many tests, but it’s not like our current package was passing them anyway. (But maybe we should just disable the jpylyzer ones unconditionally if they all fail, if that’s a thing we can do.)
pkgs/by-name/op/openjpeg/package.nix
Outdated
There was a problem hiding this comment.
BUILD_TESTING is automatically set, no need to do it ourselves.
There was a problem hiding this comment.
BUILD_TESTINGis automatically set, no need to do it ourselves.
if I don't set it no tests run.
openjpeg> No tests were found!!!
There was a problem hiding this comment.
Weird. I guess they flip the default or something.
pkgs/by-name/op/openjpeg/package.nix
Outdated
There was a problem hiding this comment.
I can check if these pass now on aarch64-linux if you’d like.
There was a problem hiding this comment.
thanks. I made a couple of tweaks to the cmakeFlags and removed "-DCMAKE_INSTALL_NAME_DIR=\${CMAKE_INSTALL_PREFIX}/lib" running the passthru.tests -- everything in -dev looks fine.
tests were failing with clang-19 due to vendoring an old zlib. However, even with the compile error fixed the tests would report success even with the majority of them failing due to a missing data directory. download the data directory to run the tests and just run tests by cmake. 8% of the tests do fail and are excluded
2 participants
the tests are re-building everything but not taking the build flags into consideration and using vendored libs which silently fail to build with clang-19 and result in failed tests due to missing binaries. Disabling 3rd party libs fixes the tests.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
@emilazy