fmt_9: add patch for Clang ≥ 18#355327
Merged
emilazy merged 1 commit intoNixOS:llvm-19from Nov 13, 2024
Merged
Conversation
paparodeo
approved these changes
Nov 12, 2024
Contributor
paparodeo
left a comment
paparodeo
left a comment
There was a problem hiding this comment.
patch just modifies tests so seems fine. i am a little curious if there are still issues with the library regarding using std::char_traits and a type that is not char or charX_t but perhaps the library doesn't utilize the unsupported types.
wegank
added
the
12.approvals: 1
ofborg
bot
added
10.rebuild-darwin: 11-100
Contributor
|
this PR needs to get merged. |
emilazy
added a commit
to emilazy/nixpkgs
that referenced
this pull request
Nov 16, 2024
emilazy
added a commit
that referenced
this pull request
Nov 17, 2024
emilazy
added a commit
to emilazy/nixpkgs
that referenced
this pull request
Nov 18, 2024
emilazy
added a commit
that referenced
this pull request
Nov 18, 2024
emilazy
added a commit
that referenced
this pull request
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Holding off on
fmt_8for now since I think I can get rid of it.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.