Merged
Conversation
Member
|
Could you add that bit of info to a code comment above the patch? @ofborg build pkgsMusl.librist |
Atemu
approved these changes
Nov 12, 2024
Member
Atemu
left a comment
Atemu
left a comment
There was a problem hiding this comment.
The patch itself is simple enough
ofborg
bot
added
10.rebuild-darwin: 501+
wegank
added
the
12.approvals: 1
alyssais
force-pushed
the
librist-musl
branch
from
ce1bf16 to
01fe6fb
Compare
github-actions
bot
removed
the
6.topic: musl
Member
Author
|
My account got approved, so I've added a link to the upstream MR. |
Member
|
@ofborg build pkgsMusl.librist |
Contributor
|
Backport failed for |
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll submit this upstream, but I have to wait for my account for the VideoLAN GitLab to be approved, and I don't know how long that will take. We have until the start of the next cycle, though, because it's too late to get this into staging-next.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.