formats.ini: expose INI atom from all ini formats#354800
Merged
infinisil merged 1 commit intoNixOS:masterfrom Nov 18, 2024
Merged
formats.ini: expose INI atom from all ini formats#354800infinisil merged 1 commit intoNixOS:masterfrom
infinisil merged 1 commit intoNixOS:masterfrom
Conversation
13 tasks
e67c9a9 to
20d8178
Compare
3771e0f to
c07b750
Compare
hsjobeki
commented
Nov 18, 2024
pkgs/pkgs-lib/formats.nix
Outdated
Contributor
Author
There was a problem hiding this comment.
Suggested change
| inherit atom; | |
| lib.types.atom = atom; |
d9d4b7a to
d15b61c
Compare
d15b61c to
6b53949
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes
INI atomfrom all ini formats.Used i.e. in
public-inboxThe old implementation was using the option-type tree to get the internal atom which seems very cumbersome.
Additionally stability of the option tree is not guaranteed as an API anywhere.
There might be future efforts to provide methods for walking an option-tree but for now, just exposing the needed thing would be much better / cleaner.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.