Skip to content

formats.ini: expose INI atom from all ini formats#354800

Merged
infinisil merged 1 commit intoNixOS:masterfrom
hsjobeki:pkgs/format-iniAtom
Nov 18, 2024
Merged

formats.ini: expose INI atom from all ini formats#354800
infinisil merged 1 commit intoNixOS:masterfrom
hsjobeki:pkgs/format-iniAtom

Conversation

@hsjobeki
Copy link
Contributor

@hsjobeki hsjobeki commented Nov 9, 2024

Exposes INI atom from all ini formats.

Used i.e. in public-inbox

The old implementation was using the option-type tree to get the internal atom which seems very cumbersome.

Additionally stability of the option tree is not guaranteed as an API anywhere.
There might be future efforts to provide methods for walking an option-tree but for now, just exposing the needed thing would be much better / cleaner.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@hsjobeki hsjobeki requested a review from jtojnar November 9, 2024 16:05
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 9, 2024
@nix-owners nix-owners bot requested a review from infinisil November 9, 2024 16:07
@hsjobeki hsjobeki force-pushed the pkgs/format-iniAtom branch from e67c9a9 to 20d8178 Compare November 9, 2024 16:15
@hsjobeki hsjobeki changed the title pkgs/formats: expose iniAtom pkgs/formats: expose gitIni.atom Nov 9, 2024
@hsjobeki hsjobeki force-pushed the pkgs/format-iniAtom branch 3 times, most recently from 3771e0f to c07b750 Compare November 9, 2024 16:21
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 10, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
inherit atom;
lib.types.atom = atom;

@hsjobeki hsjobeki force-pushed the pkgs/format-iniAtom branch 3 times, most recently from d9d4b7a to d15b61c Compare November 18, 2024 15:06
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Nov 18, 2024
@hsjobeki hsjobeki force-pushed the pkgs/format-iniAtom branch from d15b61c to 6b53949 Compare November 18, 2024 15:08
@hsjobeki hsjobeki changed the title pkgs/formats: expose gitIni.atom formats.ini: expose INI atom from all ini formats Nov 18, 2024
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed together in a meeting with @hsjobeki, looking good!

@infinisil infinisil merged commit 555f0e9 into NixOS:master Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants