lib/types: init {types.attrsWith}#354738
Merged
infinisil merged 6 commits intoNixOS:masterfrom Dec 2, 2024
Merged
Conversation
github-actions
bot
added
6.topic: module system
ofborg
bot
added
10.rebuild-darwin: 1-10
hsjobeki
force-pushed
the
lib/attrsWith
branch
from
327fe92 to
c4a9529
Compare
Co-Authored-By: @hsjobeki
infinisil
reviewed
Nov 25, 2024
Member
hsjobeki
force-pushed
the
lib/attrsWith
branch
from
4973006 to
3b2f920
Compare
Co-Authored-By: @infinisil
hsjobeki
force-pushed
the
lib/attrsWith
branch
from
3b2f920 to
45f0035
Compare
Contributor
Author
|
@infinisil Depraction message works now. With/without type merging. |
Co-Authored-By: Johannes Kirschbauer <[email protected]>
github-actions
bot
removed
the
10.rebuild-darwin: 1
infinisil
force-pushed
the
lib/attrsWith
branch
from
dd5e03e to
d5eccbb
Compare
Contributor
|
this change seems like it broke one of the ofborg eval tests. |
13 tasks
Contributor
|
So do we revert this or does anyone have a quick fix? |
13 tasks
Contributor
|
Reverted. |
Member
|
We will add lib-tests soon to github ci. |
13 tasks
Contributor
Author
|
@infinisil @K900 Please just remove the failing test line. It was only there for testing the "nice" deprecation message. But it seems the test framework cannot handle that yet. I would need to first fix the test framework. Which is a bit more work. I am not sure what the convention is for reverting a revert but i opened up this one: |
This was referenced Dec 3, 2024
Member
|
The convention is to revert the revert and than potentially fix the issue. |
4 tasks
This was referenced Dec 3, 2024
Merged
This was referenced Dec 4, 2024
Merged
Merged
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
types.attrsWithcombinesattrsOfandlazyAttrsOfwith a configurablelazy = true/falseparameter.Other parameters are possible and on hold see: #344216
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.