Skip to content

ch9344: 2.0 -> 0-unstable-2024-11-15#354536

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
MakiseKurisu:ch9344-2.1
Dec 12, 2024
Merged

ch9344: 2.0 -> 0-unstable-2024-11-15#354536
wolfgangwalther merged 1 commit intoNixOS:masterfrom
MakiseKurisu:ch9344-2.1

Conversation

@MakiseKurisu
Copy link
Contributor

@MakiseKurisu MakiseKurisu commented Nov 8, 2024 •
edited
Loading

Updated to v2.1, which was released on 2024-10-26.

Changelog from the driver source code:

 * V2.1 - remove put_char and flush_chars methods of tty_operations
 *      - add support for kernel version beyond 6.5.x
 *      - add support for ch9344q
 *      - update modem status when uart open

Update 1: Package is now tracking WCH's GitHub repository, which is more stable.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@MakiseKurisu MakiseKurisu added 8.has: package (update) This PR updates a package to a newer version 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 8.has: changelog This PR adds or changes release notes labels Nov 8, 2024
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Nov 8, 2024
@MakiseKurisu
Copy link
Contributor Author

MakiseKurisu commented Nov 11, 2024

Can someone explain to me why the bot failed? Was it because of my PR?

@FliegendeWurst
Copy link
Member

FliegendeWurst commented Nov 22, 2024

@ofborg build ch9344

ofborg sometimes fails, it has nothing to do with your PR in particular.

FliegendeWurst
FliegendeWurst reviewed Nov 22, 2024
View reviewed changes
FliegendeWurst
FliegendeWurst reviewed Nov 22, 2024
View reviewed changes
pkgs/os-specific/linux/ch9344/default.nix Outdated
Copy link
Member

@FliegendeWurst FliegendeWurst Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace with an archived URL

Copy link
Contributor Author

@MakiseKurisu MakiseKurisu Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently tracking WCH's GitHub instead. Unfortunately, as the versioning is a mess (mentioned in the commit message), package is now treated as having no upstream versioning.

Copy link
Contributor

@blitz blitz Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also independently figured out that their Github is a better source than their release zips. The URL for the release zips stays the same but the content is updated when they have a new release.

@github-actions github-actions bot removed the 8.has: changelog This PR adds or changes release notes label Nov 25, 2024
@MakiseKurisu MakiseKurisu changed the title ch9344: 2.0 -> 2.1 ch9344: 2.0 -> 0-unstable-2024-11-15 Nov 25, 2024
@MakiseKurisu MakiseKurisu removed the ofborg-internal-error Ofborg encountered an error label Nov 25, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 26, 2024
FliegendeWurst
FliegendeWurst reviewed Nov 28, 2024
View reviewed changes
@MakiseKurisu MakiseKurisu force-pushed the ch9344-2.1 branch 2 times, most recently from 4a7edcd to c65bb27 Compare November 28, 2024 11:53
blitz
blitz approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@blitz blitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! It would be really great to merge this because it spams nixpkgs-review. :)

@blitz blitz requested a review from K900 November 28, 2024 13:58
@blitz blitz mentioned this pull request Nov 28, 2024
Merged
18 tasks
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Nov 28, 2024
SuperSandro2000
SuperSandro2000 reviewed Dec 3, 2024
View reviewed changes
@MakiseKurisu
ch9344: 2.0 -> 0-unstable-2024-11-15
c353ff9 
GitHub repository does not contain versioned tags. The version mentioned
in the commit message also does not match the change log embedded in the
source code, which seems to be where the official version came from.

Since this is such a mess, treat the package as no versioning.
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Dec 4, 2024
@wegank wegank added the 12.approvals: 3+ This PR was reviewed and approved by three or more persons. label Dec 5, 2024
@MakiseKurisu
Copy link
Contributor Author

MakiseKurisu commented Dec 5, 2024

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

nixpkgs-merge-bot bot commented Dec 5, 2024

@MakiseKurisu merge not permitted (#305350):
pkgs/os-specific/linux/ch9344/default.nix is not in pkgs/by-name/
pkgs/os-specific/linux/ch9344/fix-incompatible-pointer-types.patch is not in pkgs/by-name/
pkgs/os-specific/linux/ch9344/fix-linux-6-12-build.patch is not in pkgs/by-name/

@wolfgangwalther wolfgangwalther merged commit cfd4bed into NixOS:master Dec 12, 2024
@MakiseKurisu MakiseKurisu deleted the ch9344-2.1 branch December 13, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@K900 K900 Awaiting requested review from K900

+1 more reviewer

@blitz blitz blitz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MakiseKurisu @FliegendeWurst @blitz @SuperSandro2000 @wolfgangwalther @wegank