Conversation
emilazy
added
6.topic: darwin
github-actions
bot
removed
the
6.topic: llvm/clang
paparodeo
approved these changes
Nov 7, 2024
ofborg
bot
added
10.rebuild-darwin-stdenv
ofborg
bot
requested review from
adevress,
amiloradovsky,
bjornfor,
edolstra,
gebner and
prusnak
ofborg
bot
added
10.rebuild-darwin: 501+
RossComputerGuy
approved these changes
Nov 7, 2024
This was referenced Nov 7, 2024
github-actions
bot
added
the
6.topic: rust
emilazy
force-pushed
the
emily/push-nkyqpvqvxwzn
branch
from
f17e590 to
f1e9c7f
Compare
github-actions
bot
removed
the
6.topic: darwin
emilazy
force-pushed
the
emily/push-nkyqpvqvxwzn
branch
from
f1e9c7f to
6e157fb
Compare
These work on Darwin, and using the system libpng avoids an issue trying to build the vendored version of libpng with clang 18.
python3Packages.pylibjpeg-openjpeg tries to access openjpeg.src which was changed to srcs in 1f9a1d0. Change it back.
…hen compiling + linking `https://github.com/llvm/llvm-project/issues/116278` make clang report unsupported option errors / warning when compiling + linking in the same command. this works ``` $ clang --target=aarch64 -mpopcnt hello.c clang: error: unsupported option '-mpopcnt' for target aarch64 ``` before change clang swallows the error ``` $ clang --target=aarch64 -mpopcnt hello.c -lc $ echo $? 0 ``` after change error is reported: ``` $ clang --target=aarch64 -mpopcnt hello.c -lc clang: error: unsupported option '-mpopcnt' for target aarch64 ```
libc++ 19 no longer supports Clang < 17. This reverts commit b034e4c.
…hen compiling + linking (#356547)
github-actions
bot
added
the
6.topic: nodejs
build failed on clang-19 fixes 82a00b7
Member
|
Ack. |
Contributor
|
Bisect says that da65c30 |
This was referenced Nov 23, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
3 tasks
3 tasks
emilazy
added a commit
to emilazy/nixpkgs
that referenced
this pull request
Sep 7, 2025
This has been de facto the case for a while now anyway, given its inseparability from my `stdenv` and Darwin team roles, especially after <NixOS#354107> and <NixOS#440273>. Might as well make sure I don’t miss pings, although I can’t promise I’ll be able to proactively review stuff that falls outside the scope that matters to me.
13 tasks
alyssais
pushed a commit
that referenced
this pull request
Sep 8, 2025
This has been de facto the case for a while now anyway, given its inseparability from my `stdenv` and Darwin team roles, especially after <#354107> and <#440273>. Might as well make sure I don’t miss pings, although I can’t promise I’ll be able to proactively review stuff that falls outside the scope that matters to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the work‐in‐progress PR for the 25.05 bump to LLVM 19. We’ve had a few Darwin people working on this independently, but the issues and patches are piling up and it’d be good to have a common branch to work on together. It’s currently based on my Darwin minimum version bump PR since that will land in the same cycle, but will be retargeted to
stagingonce the branch‐off happens and that PR is merged. Please feel free to send PRs to this branch.Known blockers:
wasm32-unknown-unknownstuff that @paparodeo is working on – still cursed, but clean‐ups have made it broken in a less visible waycc @NixOS/llvm @NixOS/darwin-core
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.