This seems fine. A good test would be to build Python with darwin-libutil.patch disabled and Neovim with #346946 reverted.

MacVim, CPython 3.10, and CPython 3.12 build successfully. Now building the other CPythons and the other packages I’ve touched here. I looked at the source for all of them except MacVim and determined that they expected <util.h>, not <libutil.h>, as expected for packages supporting Darwin or BSD upstream. I have not tested MacVim as it requires Xcode; cc @lilyball.

There are no packages left referencing darwin.libutil except the SDK; maybe it should not really be installing libutil.h at all, since apparently nothing wants it on macOS.

I have confirmed that everything touched here builds (except macvim as stated previously, but I’m pretty sure it’s not likely to be the one package in the whole tree that actually needs this, especially given that it has since had changes to depend less on Nix stuff).

@reckenrode There are now no users of darwin.libutil that don’t use lib.getLib, because everything uses <util.h> on macOS and various BSDs. Are we sure we want to install the <libutil.h> header in that package at all? In any case, the only explicit user outside of the SDK is now libuv, which has to build with the bootstrap SDK. Let me know if you think I’ve handled it appropriately there or if there’s something nicer we could do.

libutil.h is used by several source releases (e.g., file_cmds, shell_cmds, system_cmds, etc).

Ah, I didn’t think of the source release scope!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/the-darwin-sdks-have-been-updated/55295/1