Merged
Conversation
Bot-wxt1221
added
the
0.kind: ZHF Fixes
skeuchel
reviewed
Nov 3, 2024
skeuchel
left a comment
skeuchel
left a comment
There was a problem hiding this comment.
LGTM. Main difference with the patch for default are fewer OS_* macros.
However, we could also drop this variant of gn entirely. It was introduced in #138359 to build envoy which has recently moved to the default gn #349028. Now gn1924 does not have any reverse dependencies anymore.
Contributor
|
I think we're better off just dropping this gn version, yeah. Sorry about that - I should've dropped it once we moved envoy off it. |
Member
Author
lukegb
approved these changes
Nov 3, 2024
skeuchel
approved these changes
Nov 3, 2024
lukegb
approved these changes
Nov 3, 2024
Bot-wxt1221
added
the
12.approvals: 2
Aleksanaa
reviewed
Nov 3, 2024
Member
Aleksanaa
left a comment
Aleksanaa
left a comment
There was a problem hiding this comment.
Please add entry in pkgs/top-level/aliases.nix
Member
Author
|
@aleks Done. |
Aleksanaa
reviewed
Nov 3, 2024
Member
Author
|
@Aleksanaa Done. |
wegank
removed
the
12.approvals: 2
ofborg
bot
added
8.has: clean-up
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZHF: #352882
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.