auto-patchelf: Don't use buildPythonApplication#353270
Merged
Scrumplex merged 1 commit intoNixOS:stagingfrom Nov 3, 2024
Merged
auto-patchelf: Don't use buildPythonApplication#353270Scrumplex merged 1 commit intoNixOS:stagingfrom
Scrumplex merged 1 commit intoNixOS:stagingfrom
Conversation
13 tasks
13 tasks
mweinelt
approved these changes
Nov 3, 2024
NixOS#340162 introduced `autoPatchelfHook` as it's own top-level attribute. This also made it use the Nixpkgs Python build infrastructure, which relies on dependency propagation, leaking Python as a dependency into many builds erroneously. This change uses a `withPackages` constructed environment instead, and manually patches the script shebangs, not triggering the `buildPython*` dependency propagation mechanism
adisbladis
force-pushed
the
auto-patchelf-dont-propagate
branch
from
d12fae8 to
687371a
Compare
Scrumplex
approved these changes
Nov 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
#340162 introduced
autoPatchelfHookas it's own top-level attribute. This also made it use the Nixpkgs Python build infrastructure, which relies on dependency propagation, leaking Python as a dependency into many builds erroneously.This change uses a
withPackagesconstructed environment instead, and manually patches the script shebangs, not triggering thebuildPython*dependency propagation mechanismnix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.